fix(feedback_note): parse student heads with a trailing suffix after ** - #21
Merged
Merged
Conversation
`_HEAD` anchored on `**$`, so a head like `### Name — **96 / 100** · ACE +14/15` silently failed to match — the block was skipped and the student vanished from delivery with no error (6 ACE students in the su26 §01 Lab 2 re-grade would have been dropped). Allow an optional `(?:\s.*)?` after the closing `**`; the required `**<total>/<grand>**` still parses unchanged. Regression test: test_head_with_trailing_suffix_parses. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015cY2osrcunEXb5a8xtTy2V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
feedback_note._HEADanchored on**$, so a per-student head with any content after the closing**— e.g. an at-a-glance### Name — **96 / 100** · ACE +14/15— silently failed to match. The block was skipped and the student vanished from delivery with no error. In the CECS 378 su26 §01 Lab 2 re-grade, the 6 students with an ACE suffix (jbavo, jaz977-7, colin-schulte, d-schulte, VScsulb, mbadberg01) would have been dropped.Fix
Allow an optional
(?:\s.*)?after the closing**. The required**<total> / <grand>**still parses unchanged; a plain head with no suffix is unaffected.Test
TDD:
test_head_with_trailing_suffix_parses(added) fails on the old regex, passes on the new one. Full suite green (388 passed).🤖 Generated with Claude Code
https://claude.ai/code/session_015cY2osrcunEXb5a8xtTy2V